Fix all warnings in QML #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patches fix all the existing warnings in version 0.3.4 emitted by qmlls, the new changes in version 0.3.5 are not yet covered:
qrc:/qt/qml)ChatViewmatches the subdirectory name to suppress CMake warning. (gitwrongly detectedChatItem.qmlas being deleted and recreated)DEPENDENCIES QtQuickto make sure qmlls can properly resolveQQuickItemUnrelated changes:
target_include_directoriesto usePRIVATEscope. Don’t add unneeded PUBLIC requirements; Other modules should include the top level directory instead and use relative path (eg..#include "ChatView/ChatWidget.hpp") to avoid potential name clashing in the futureThe patches has been tested against the latest commit, on Qt Creator 14.0.2 (Windows 11). All functionalities seem to continue working.